Skip to content

Fix Astro integration test by pinning zod-to-json-schema #14780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix Astro integration test by pinning zod-to-json-schema #14780

merged 1 commit into from
Oct 24, 2024

Conversation

@philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Oct 24, 2024 •
edited
Loading

A regression in one of the dependencies of astro has broken our integration tests. An upstream issue already exists and is tracked as StefanTerdell/zod-to-json-schema#151.

This PR pins zod-to-json-schema to unblock the issue.

Test Plan

  1. I made sure that pnpm test:integrations astro fails locally as well
  2. After the change, it passes again:
    Screenshot 2024-10-24 at 17.16.27.png

@philipp-spiess Graphite App
Copy link
Member Author

philipp-spiess commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @philipp-spiess and the rest of your teammates on Graphite Graphite

@philipp-spiess philipp-spiess marked this pull request as ready for review October 24, 2024 15:16
@philipp-spiess philipp-spiess requested a review from a team as a code owner October 24, 2024 15:16
adamwathan
adamwathan approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@adamwathan adamwathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@RobinMalfait RobinMalfait enabled auto-merge (squash) October 24, 2024 15:18
@RobinMalfait RobinMalfait merged commit 8605426 into next Oct 24, 2024
2 checks passed
@RobinMalfait RobinMalfait deleted the 10-24-fix_astro_integration_test_by_pinning_zod-to-json-schema_ branch October 24, 2024 15:18
@StefanTerdell
Copy link

StefanTerdell commented Oct 25, 2024

Just FYI @philipp-spiess you can remove this now if you want 🙃

philipp-spiess added a commit that referenced this pull request Oct 25, 2024
@philipp-spiess
Revert "Fix Astro integration test by pinning zod-to-json-schema (#…
6f5f7be 
…14780)"

This reverts commit 8605426.
@philipp-spiess philipp-spiess mentioned this pull request Oct 25, 2024
Merged
@philipp-spiess
Copy link
Member Author

philipp-spiess commented Oct 25, 2024

@StefanTerdell awesome, thank you :)

philipp-spiess added a commit that referenced this pull request Oct 25, 2024
@philipp-spiess
Revert "Fix Astro integration test by pinning zod-to-json-schema" (#…
5b2f6c7 
…14792)

Reverts #14780

The version pin is no longer needed. 🙂 

## Test Plan

CI is green again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwathan adamwathan adamwathan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@philipp-spiess @StefanTerdell @adamwathan @RobinMalfait