@source globs should apply auto source detection
#14814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proves that right now when using a glob, that files that should be git ignored are _not_ git ignored.
This test now makes sure that: 1. If a glob is used, and it contains `**`, then it should _not_ resolve ignored files/folders like `node_modules`. 2. If an explicit glob is used that contains `node_modules`, then we will resolve files in this folder. 3. If an explicit glob is used, and that glob includes file extensions we normally ignore then those files should resolve because the glob is explicit.
This gives us stable results, which is useful during debugging and in tests
And make sure that we break once we find a `!`.
This is to ensure that matching files is correct.
This was referenced Oct 28, 2024
Merged
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RobinMalfait and the rest of your teammates on |
|
closed in favor of #14820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.