Fix path issues in CLI #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147.
When enforcing our lint rules, a subtle bug was introduced where paths were being resolved to the root of the file system instead of relative to where the CLI source file was located.
This is because of the leading slash in the second argument to
path.resolve:Originally this was written as:
...which worked fine, but failed ESLint. Swapping the
+for a,causedpath.resolveto treat the second path as absolute and resolve to just that path on it's own.This change gets rid of the leading slash so the path is properly resolved as relative to
__dirname.This change also stops the CLI from loading the user's config file before passing it in for processing. Previously we supported passing a config object rather than just a path, but when removing that option, we made the mistake of not updating the CLI tool to pass a path instead of an object.