Skip to content

Conversation

@adamwathan
Copy link
Member

This PR reverts a change we made for v4 that added borders to inputs by default. It feels like we have to go further than this for this to actually be useful to anyone, and since there were no borders in v3 it's also a breaking change.

If we wanted to make form elements look more "normal" out of the box I think we need to do something more like this:

https://play.tailwindcss.com/icCwFLVp4z?file=css

But it's a huge rabbit hole and there are so many stupid details to get right that it feels like an insurmountable task, and if we can't go all the way with it it's better to just maximize compatibility with v3.

@adamwathan adamwathan requested a review from a team as a code owner November 8, 2024 20:12
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only deleted code, this gets an approval by default!

image

But probably needs a changelog entry 😅

@adamwathan adamwathan enabled auto-merge (squash) November 8, 2024 20:29
@adamwathan adamwathan disabled auto-merge November 8, 2024 20:29
@adamwathan adamwathan merged commit 56288a3 into next Nov 8, 2024
1 check passed
@adamwathan adamwathan deleted the change/remove-input-borders branch November 8, 2024 20:29
tongrow pushed a commit to tongrow/tailwind-normalize that referenced this pull request Jun 2, 2025
This PR reverts a change we made for v4 that added borders to inputs by
default. It feels like we have to go further than this for this to
actually be useful to anyone, and since there were no borders in v3 it's
also a breaking change.

If we wanted to make form elements look more "normal" out of the box I
think we need to do something more like this:

https://play.tailwindcss.com/icCwFLVp4z?file=css

But it's a huge rabbit hole and there are so many stupid details to get
right that it feels like an insurmountable task, and if we can't go all
the way with it it's better to just maximize compatibility with v3.

---------

Co-authored-by: Adam Wathan <4323180+adamwathan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants