Upgrade: don't show error during upgrade when analyzing external URL import #15040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Nov 19, 2024
philipp-spiess
approved these changes
Nov 19, 2024
This code wasn't used, so let's clean it up.
This guarantees that: 1. The `@import` is not modified in any way, shape or form 2. The `@import` doesn't crash the rest of the system 3. Imports later in the file are still migrated as expected
402bc9d to
973b93b
Compare
thecrypticace
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the output of the upgrade tool when we are handling imports and the import happens to be an external URL.
External URLs shouldn't and can't be upgraded, so printing an error message doesn't help the user.
Additionally, if an
@importis using theurl(…)function, then we skip over it and continue with the rest of the imports.Running this on github.com/parcel-bundler/parcel