Use resolveJsId when resolving tailwindcss/package.json
#15041
Merged
+365
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Bun, it looks like the `createRequire(…)` doesn't work as expected if you run the script from a different location (even if you provide the base path). We already use enhanced resolver which we can re-use for this.
b70f7dc to
edaef14
Compare
thecrypticace
approved these changes
Nov 19, 2024
philipp-spiess
approved these changes
Nov 19, 2024
thecrypticace
pushed a commit
that referenced
this pull request
Nov 19, 2024
This PR updates the `jiti` dependency we use for plugin loading to the latest stable release. ## Test Plan This was relying on integration tests which contains example of TypeScript configs. It's also rebased to include the new examples from #15041.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
enhanced-resolveinstead ofcreateRequire(…).resolvewhich improves the usability when running the upgrade tool locally using Bun.While testing, we also noticed that it is not possible to use a
cjs-only plugin inside of anesmproject. It was also not possible to use anesm-only plugin inside of acjsproject.Test plan
We added integration tests in both the CLI (the CLI is an mjs project) and in the PostCSS (where we can configure a
cjsandesmPostCSS config) integration tests where we created anesmandcjsbased project with 4 plugins (cjs-only,esm-only, and TypeScript based plugins:cts-only andmts-only).