Move errant SVG and extract nav links to a partial #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Real interesting. Almost makes me think we should go full on and do this for the entire nav. Ie. One big data structure. Was there a reason you didn't do that? |
|
@reinink I'd love to!! just didn't want to go overboard :) If y'all are up for it I will |
|
I think it might actually be better that way, so I say go for it! 🏄 Thanks buddy 😍 |
|
@reinink OK, ready for review. Thanks! |
|
Hmm, I think we lost at least three pages in the nav:
|
reinink
requested changes
Nov 9, 2017
|
@reinink brought back--thanks for catching! 😳 |
|
YOU ROCK @mattstauffer |
reinink
approved these changes
Nov 9, 2017
DCzajkowski
pushed a commit
to DCzajkowski/tailwindcss
that referenced
this pull request
Jul 23, 2019
Fix typo in navigation.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This only extracts the child links, not the parent; we could make that a separate partial or just keep it in the code like it is now.