Skip to content

Fix Vite issues with SolidStart #16052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinMalfait merged 7 commits into from
Jan 30, 2025
Merged

Fix Vite issues with SolidStart #16052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aaa2c02
Don't invalidate roots on rebuilds
philipp-spiess Jan 30, 2025
92e5405
Ignore html resouces without a path
philipp-spiess Jan 30, 2025
81e5f04
Add SolidStart test
philipp-spiess Jan 30, 2025
48871b4
add change log
philipp-spiess Jan 30, 2025
075d202
Add comment
philipp-spiess Jan 30, 2025
25edeb1
Update CHANGELOG.md
philipp-spiess Jan 30, 2025
5f13aae
Merge branch 'main' into fix/vite-issues
RobinMalfait Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@philipp-spiess
philipp-spiess committed Jan 30, 2025
commit 075d2020149308d5eb8b6fac0d0b432be6b446ee
6 changes: 2 additions & 4 deletions packages/@tailwindcss-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,12 @@ export default function tailwindcss(): Plugin[] {
}

function invalidateAllRoots() {
let rootsFound = new Set()

for (let server of servers) {
let updates: Update[] = []
for (let [id] of roots.entries()) {
let module = server.moduleGraph.getModuleById(id)
if (!module) continue

rootsFound.add(id)

roots.get(id).requiresRebuild = false
server.moduleGraph.invalidateModule(module)
updates.push({
Expand Down Expand Up @@ -203,7 +199,9 @@ export default function tailwindcss(): Plugin[] {

// Scan all non-CSS files for candidates
transformIndexHtml(html, { path }) {
// SolidStart emits HTML chunks with an undefined path and the html content of `\`.
if (!path) return

scanFile(path, html, 'html')
},
transform(src, id, options) {
Expand Down