-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add Haml pre processor #17051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haml pre processor #17051
Conversation
|
I just tried this on the insiders track and it is mostly working! Unfortunately, I'm still having some odd troubles. For example I'm going to clone the repo and see if I can add some tests to do some more debugging and see if I can come up with additional tests that would be helpful. Thanks for your work on this! 🙌 |
|
@topherfangio with just the input you shared it seems to work for me. Can you check 2 things for me:
If you can come up with a fix that would be nice, if not, a new GitHub issue with a minimal reproduction repo attached would be appreciated. That way we can link to the issue in the new PR and keep it easier to track issues 👍 |
|
I cloned the project and am tying to get started with it but running into some issues. I'll try to put together a repo that reproduces it, but in the meantime, you can see the failing HAML file here: https://github.com/profoundry-us/loco_motion/blob/main/docs/demo/app/views/application/home.html.haml Thanks for looking into this! |
|
@RobinMalfait Here is the reproduction URL. https://github.com/profoundry-us/tailwind4-issues-reproduction I tested a handful of other classes, and the only one I noticed missing was the |
|
@topherfangio thanks! Fix incoming here: |
|
@RobinMalfait You are awesome!!! Thank you so much! 🙌 |
This PR ensures we extract candidates from Haml files.
Fixes: #17050