Skip to content

Fix segmentation fault when loading @tailwindcss/oxide in a Worker thread #17276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 7 commits into from
Mar 18, 2025
Merged

Fix segmentation fault when loading @tailwindcss/oxide in a Worker thread #17276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a00da1c
Fix segmentation fault when loading @tailwindcss/oxide in a Worker th…
devongovett Mar 18, 2025
bbde650
Add integration test
thecrypticace Mar 18, 2025
bb1a944
Add integration test group
thecrypticace Mar 18, 2025
7ee683f
Move rust flags
thecrypticace Mar 18, 2025
b4ab8e2
Tweak test a bit
thecrypticace Mar 18, 2025
c6c4d39
Add cargo config to turborepo cache inputs
thecrypticace Mar 18, 2025
cd0a6fe
Update changelog
thecrypticace Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move rust flags
  • Loading branch information
@thecrypticace
thecrypticace committed Mar 18, 2025
commit 7ee683f8eed7919edd56eaa13afc7ba02b23b238
2 changes: 0 additions & 2 deletions .cargo/config.toml
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions crates/node/.cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ linker = "arm-linux-gnueabihf-gcc"
rustflags = ["-C", "target-feature=+crt-static"]
[target.aarch64-pc-windows-msvc]
rustflags = ["-C", "target-feature=+crt-static"]
[target.'cfg(target_env = "gnu")']
rustflags = ["-C", "link-args=-Wl,-z,nodelete"]
Copy link
Contributor

@thecrypticace thecrypticace Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to do this way b/c we only pass compiler flags for Musl which isn't affected by this rust bug