Skip to content

Add support for literal values in --value('…') and --modifier('…') #17304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 20, 2025
Merged

Add support for literal values in --value('…') and --modifier('…') #17304

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b97c24
add tests for `--value('literal')` and `--modifier('literal')` values
RobinMalfait Mar 20, 2025
033ae4b
add literal value support for `--value('…')` and `--modifier('…')`
RobinMalfait Mar 20, 2025
ebb1c1f
update changelog
RobinMalfait Mar 20, 2025
d5fcfa1
update API description
RobinMalfait Mar 20, 2025
a983de4
add failing suggestions test
RobinMalfait Mar 20, 2025
ca655f4
track literal `--value('…')` and `--modifier('…')` values for suggest…
RobinMalfait Mar 20, 2025
c4c9c49
remove unnecessary replacement
RobinMalfait Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update API description
  • Loading branch information
@RobinMalfait
RobinMalfait committed Mar 20, 2025
commit d5fcfa1f2fcb602efa181a92e0da2cc4aa951865
13 changes: 7 additions & 6 deletions packages/tailwindcss/src/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4706,6 +4706,7 @@ export function createCssUtility(node: AtRule) {
if (IS_VALID_FUNCTIONAL_UTILITY_NAME.test(name)) {
// API:
//
// - `--value('literal')` resolves a literal named value
// - `--value(number)` resolves a bare value of type number
// - `--value([number])` resolves an arbitrary value of type number
// - `--value(--color)` resolves a theme value in the `color` namespace
Expand Down Expand Up @@ -4747,12 +4748,12 @@ export function createCssUtility(node: AtRule) {

// Required manipulations:
//
// - `--value(--spacing)` -> `--value(--spacing-*)`
// - `--value(--spacing- *)` -> `--value(--spacing-*)`
// - `--value(--text- * --line-height)` -> `--value(--text-*--line-height)`
// - `--value(--text --line-height)` -> `--value(--text-*--line-height)`
// - `--value(--text-\\* --line-height)` -> `--value(--text-*--line-height)`
// - `--value([ *])` -> `--value([*])`
// - `--value(--spacing)` -> `--value(--spacing-*)`
// - `--value(--spacing- *)` -> `--value(--spacing-*)`
// - `--value(--text- * --line-height)` -> `--value(--text-*--line-height)`
// - `--value(--text --line-height)` -> `--value(--text-*--line-height)`
// - `--value(--text-\\* --line-height)` -> `--value(--text-*--line-height)`
// - `--value([ *])` -> `--value([*])`
//
// Once Prettier / Biome handle these better (e.g.: not crashing without
// `\\*` or not inserting whitespace) then most of these can go away.
Expand Down