Fix Ruby files causing the CLI to hang #17383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't put this test case in because it's kinda absurd but this froze previously with the old regex — yes the indentation is like that on purpose: // https://github.com/tailwindlabs/tailwindcss/issues/17334
#[test]
fn test_wip() {
let input = r#"
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
<div class="underline underline underline underline underline underline underline underline underline"></div>
"#;
Ruby::test_extract_contains(input, vec!["underline"]);
} |
philipp-spiess
approved these changes
Mar 26, 2025
philipp-spiess
added a commit
that referenced
this pull request
Mar 26, 2025
Fixes #17379 The preprocessor we added to detect embedded languages uses a back reference and given a long enough file with certain byte / character patterns it'll cause what appears to be an indefinite hang (might just be catastrophically exponential backtracking but not sure) This replaces the one regex w/ back references with two, anchored, multi-line regexes Now we search for all the starting & ending delimiters in the file. We then loop over all the starting delimiters, find the paired ending one, and preprocess the content inside --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
philipp-spiess
added a commit
that referenced
this pull request
Mar 28, 2025
Fixes #17379 The preprocessor we added to detect embedded languages uses a back reference and given a long enough file with certain byte / character patterns it'll cause what appears to be an indefinite hang (might just be catastrophically exponential backtracking but not sure) This replaces the one regex w/ back references with two, anchored, multi-line regexes Now we search for all the starting & ending delimiters in the file. We then loop over all the starting delimiters, find the paired ending one, and preprocess the content inside --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17379
The preprocessor we added to detect embedded languages uses a back reference and given a long enough file with certain byte / character patterns it'll cause what appears to be an indefinite hang (might just be catastrophically exponential backtracking but not sure)
This replaces the one regex w/ back references with two, anchored, multi-line regexes
Now we search for all the starting & ending delimiters in the file. We then loop over all the starting delimiters, find the paired ending one, and preprocess the content inside