-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add text-shadow-* utilities
#17389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text-shadow-* utilities
#17389
Conversation
84c72ca to
52a7f0f
Compare
|
@philipp-spiess I think you might have used an old play link, which is my bad. I updated the link in trello but not in discord. (New link) I readjusted the scale so it goes from |
|
@danhollick Ah great spot, updated it and also ran your play through a Vite project to make sure it's creating the right CSS: https://tailwind-text-shadows-preview-2kdnjb32b.vercel.app/ |
|
@philipp-spiess Can we add UI tests for this one to make sure the shadow colors work? Like the box-shadow utilities we have to not really use the variables here annoyingly for the colors to work, so if we ever forget that and try to refactor it to use variables it would be good to have tests that fail. |
`shadow-<color>` is used for box-shadow, the right name is `text-shadow-<color>` according to tailwindlabs/tailwindcss#17389.

This PR adds new
text-shadow-*utilities and default values courtesy of @danhollick's.Usage is similar to the normal
shadow-*utilities, for example:Since this PR also adds first-class support for the
--text-shadowtheme namespace, it also means it resolves #17047.Test plan
vitesetup and ran a production build to ensure it looks correct: https://tailwind-text-shadows-preview-2kdnjb32b.vercel.app/