Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
56883e7
WIP
philipp-spiess Mar 26, 2025
747dacf
Do what needs to be done
philipp-spiess Mar 27, 2025
40ba52b
Improve Next.js playground
philipp-spiess Mar 28, 2025
5183f44
De-duplicate `lightningcss` configuration
philipp-spiess Mar 28, 2025
6937fef
Simplify `color-mix(…)` inlining and adding unit tests
philipp-spiess Mar 28, 2025
e7f48b6
Revert changes to tsconfig
philipp-spiess Mar 28, 2025
19e4beb
Update snapshots
philipp-spiess Mar 28, 2025
f3e2993
Make the `@property` stuff disable-able
philipp-spiess Mar 28, 2025
1460365
PostCSS should not polyfill `@property` for CSS module files
philipp-spiess Mar 28, 2025
f6f78b1
Update more snapshots
philipp-spiess Mar 28, 2025
4c01e6f
Update snapshots
philipp-spiess Mar 31, 2025
74c5cef
Emit `@property` fallbacks at the beginning of the file
philipp-spiess Mar 31, 2025
eb801de
Add test case to stuff
philipp-spiess Mar 31, 2025
77eb998
Update snapshots
philipp-spiess Mar 31, 2025
e4ecce7
Refactor `replaceShadowColors(…)` to print AST
philipp-spiess Mar 31, 2025
9bddc09
Add fallbacks for new relative color usage
philipp-spiess Mar 31, 2025
8f09cac
More snapshot updates and comments
philipp-spiess Mar 31, 2025
5be1398
Don't use regex for replacement
philipp-spiess Mar 31, 2025
78e10dc
Further reduce the precision of color values because lightningcss pre…
philipp-spiess Mar 31, 2025
cbcf42a
Fix regex
philipp-spiess Mar 31, 2025
0ad7aad
Fix Svelte tests
philipp-spiess Mar 31, 2025
0bbcd09
Still needs a layer and fix supports query
philipp-spiess Mar 31, 2025
7d6fabc
Even more snapshot updates
philipp-spiess Mar 31, 2025
66c2c48
So. Many. Snapshots
philipp-spiess Mar 31, 2025
ddace46
Apply cleanups and also flag `color-mix(…)` polyfills so they aren't …
philipp-spiess Apr 1, 2025
8e54832
Revert changes to `replaceShadowColors(…)` and move polyfill closer t…
philipp-spiess Apr 1, 2025
79144ce
Update color values in `colors.ts`
philipp-spiess Apr 1, 2025
9244037
Update snapshots
philipp-spiess Apr 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor replaceShadowColors(…) to print AST
  • Loading branch information
philipp-spiess committed Apr 1, 2025
commit e4ecce712c8b082175a774d77f54a62f50282dbc
67 changes: 37 additions & 30 deletions packages/tailwindcss/src/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4999,9 +4999,11 @@ export function createUtilities(theme: Theme) {
return [
textShadowProperties(),
decl('--tw-text-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'text-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-text-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-text-shadow-color, ${color})`,
),
]
}
Expand All @@ -5023,13 +5025,11 @@ export function createUtilities(theme: Theme) {
return [
textShadowProperties(),
decl('--tw-text-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'text-shadow',
replaceShadowColors(
value,
alpha,
(color) => `var(--tw-text-shadow-color, ${color})`,
),
value,
alpha,
(color) => `var(--tw-text-shadow-color, ${color})`,
),
]
}
Expand All @@ -5049,9 +5049,11 @@ export function createUtilities(theme: Theme) {
return [
textShadowProperties(),
decl('--tw-text-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'text-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-text-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-text-shadow-color, ${color})`,
),
]
}
Expand Down Expand Up @@ -5139,9 +5141,11 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-shadow-color, ${color})`,
),
decl('box-shadow', cssBoxShadowValue),
]
Expand All @@ -5165,9 +5169,11 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-shadow-color, ${color})`,
),
decl('box-shadow', cssBoxShadowValue),
]
Expand All @@ -5192,9 +5198,11 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-shadow-color, ${color})`,
),
decl('box-shadow', cssBoxShadowValue),
]
Expand Down Expand Up @@ -5254,9 +5262,11 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-inset-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-inset-shadow',
replaceShadowColors(value, alpha, (color) => `var(--tw-inset-shadow-color, ${color})`),
value,
alpha,
(color) => `var(--tw-inset-shadow-color, ${color})`,
),
decl('box-shadow', cssBoxShadowValue),
]
Expand All @@ -5280,13 +5290,12 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-inset-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-inset-shadow',
`inset ${replaceShadowColors(
value,
alpha,
(color) => `var(--tw-inset-shadow-color, ${color})`,
)}`,
value,
alpha,
(color) => `var(--tw-inset-shadow-color, ${color})`,
'inset ',
),
decl('box-shadow', cssBoxShadowValue),
]
Expand All @@ -5312,13 +5321,11 @@ export function createUtilities(theme: Theme) {
return [
boxShadowProperties(),
decl('--tw-inset-shadow-alpha', alpha),
decl(
...replaceShadowColors(
'--tw-inset-shadow',
replaceShadowColors(
value,
alpha,
(color) => `var(--tw-inset-shadow-color, ${color})`,
),
value,
alpha,
(color) => `var(--tw-inset-shadow-color, ${color})`,
),
decl('box-shadow', cssBoxShadowValue),
]
Expand Down
61 changes: 35 additions & 26 deletions packages/tailwindcss/src/utils/replace-shadow-colors.test.ts
Original file line number Diff line number Diff line change
@@ -1,72 +1,81 @@
import { expect, it } from 'vitest'
import { toCss } from '../ast'
import { replaceShadowColors } from './replace-shadow-colors'

const table = [
{
input: 'var(--my-shadow)',
output: 'var(--my-shadow)',
input: ['text-shadow', 'var(--my-shadow)'],
output: 'text-shadow: var(--my-shadow);',
},
{
input: '1px var(--my-shadow)',
output: '1px var(--my-shadow)',
input: ['text-shadow', '1px var(--my-shadow)'],
output: 'text-shadow: 1px var(--my-shadow);',
},
{
input: '1px 1px var(--my-color)',
output: '1px 1px var(--tw-shadow-color, var(--my-color))',
input: ['text-shadow', '1px 1px var(--my-color)'],
output: 'text-shadow: 1px 1px var(--tw-shadow-color, var(--my-color));',
},
{
input: '0 0 0 var(--my-color)',
output: '0 0 0 var(--tw-shadow-color, var(--my-color))',
input: ['text-shadow', '0 0 0 var(--my-color)'],
output: 'text-shadow: 0 0 0 var(--tw-shadow-color, var(--my-color));',
},
{
input: '1px 2px',
output: '1px 2px var(--tw-shadow-color, currentcolor)',
input: ['text-shadow', '1px 2px'],
output: 'text-shadow: 1px 2px var(--tw-shadow-color, currentcolor);',
},
{
input: '1px 2px 3px',
output: '1px 2px 3px var(--tw-shadow-color, currentcolor)',
input: ['text-shadow', '1px 2px 3px'],
output: 'text-shadow: 1px 2px 3px var(--tw-shadow-color, currentcolor);',
},
{
input: '1px 2px 3px 4px',
output: '1px 2px 3px 4px var(--tw-shadow-color, currentcolor)',
input: ['text-shadow', '1px 2px 3px 4px'],
output: 'text-shadow: 1px 2px 3px 4px var(--tw-shadow-color, currentcolor);',
},
{
input: ['var(--my-shadow)', '1px 1px var(--my-color)', '0 0 1px var(--my-color)'].join(', '),
output: [
input: [
'text-shadow',
['var(--my-shadow)', '1px 1px var(--my-color)', '0 0 1px var(--my-color)'].join(', '),
],
output: `text-shadow: ${[
'var(--my-shadow)',
'1px 1px var(--tw-shadow-color, var(--my-color))',
'0 0 1px var(--tw-shadow-color, var(--my-color))',
].join(', '),
].join(', ')};`,
},
{
input: '1px 1px var(--my-color)',
input: ['text-shadow', '1px 1px var(--my-color)'],
intensity: '50%',
output: '1px 1px var(--tw-shadow-color, oklab(from var(--my-color) l a b / 50%))',
output: 'text-shadow: 1px 1px var(--tw-shadow-color, oklab(from var(--my-color) l a b / 50%));',
},
{
input: '1px 2px 3px 4px',
input: ['text-shadow', '1px 2px 3px 4px'],
intensity: '50%',
output: '1px 2px 3px 4px var(--tw-shadow-color, oklab(from currentcolor l a b / 50%))',
output:
'text-shadow: 1px 2px 3px 4px var(--tw-shadow-color, oklab(from currentcolor l a b / 50%));',
},
{
input: ['var(--my-shadow)', '1px 1px var(--my-color)', '0 0 1px var(--my-color)'].join(', '),
input: [
'text-shadow',
['var(--my-shadow)', '1px 1px var(--my-color)', '0 0 1px var(--my-color)'].join(', '),
],
intensity: '50%',
output: [
output: `text-shadow: ${[
'var(--my-shadow)',
'1px 1px var(--tw-shadow-color, oklab(from var(--my-color) l a b / 50%))',
'0 0 1px var(--tw-shadow-color, oklab(from var(--my-color) l a b / 50%))',
].join(', '),
].join(', ')};`,
},
]

it.each(table)(
'should replace the color of box-shadow $input with $output',
({ input, intensity = null, output }) => {
let parsed = replaceShadowColors(
input,
input[0],
input[1],
intensity,
(color) => `var(--tw-shadow-color, ${color})`,
)
expect(parsed).toEqual(output)
expect(toCss(parsed).trim()).toEqual(output)
},
)
7 changes: 5 additions & 2 deletions packages/tailwindcss/src/utils/replace-shadow-colors.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import { decl, type AstNode } from '../ast'
import { replaceAlpha } from '../utilities'
import { segment } from './segment'

const KEYWORDS = new Set(['inset', 'inherit', 'initial', 'revert', 'unset'])
const LENGTH = /^-?(\d+|\.\d+)(.*?)$/g

export function replaceShadowColors(
property: string,
input: string,
intensity: string | null | undefined,
replacement: (color: string) => string,
) {
prefix: string = '',
): AstNode[] {
let shadows = segment(input, ',').map((shadow) => {
shadow = shadow.trim()
let parts = segment(shadow, ' ').filter((part) => part.trim() !== '')
Expand Down Expand Up @@ -49,5 +52,5 @@ export function replaceShadowColors(
return `${shadow} ${replacementColor}`
})

return shadows.join(', ')
return [decl(property, `${prefix}${shadows.join(', ')}`)]
}