Add experimental @tailwindcss/oxide-wasm32-wasi
#17558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d377cc8 to
b9b3e6b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
da756d2 to
3f29edb
Compare
@tailwindcss/oxide-wasm@tailwindcss/oxide-wasm32-wasi
3f29edb to
6eedd0a
Compare
bf66895 to
478ce9e
Compare
478ce9e to
9239a0b
Compare
32447e6 to
387aef3
Compare
601e3fa to
3160eb4
Compare
3160eb4 to
4cf1fc7
Compare
@tailwindcss/oxide-wasm32-wasi@tailwindcss/oxide-wasm32-wasi
thecrypticace
approved these changes
Apr 11, 2025
Contributor
thecrypticace
left a comment
There was a problem hiding this comment.
this looks good to me. Would be good to have @RobinMalfait look at the CI workflow changes
philipp-spiess
commented
Apr 11, 2025
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ./target/ |
Member
Author
There was a problem hiding this comment.
Remove these since 1) they are not part of the hash and 2) are already cached in the cache-cargo action before this one.
RobinMalfait
approved these changes
Apr 11, 2025
Member
RobinMalfait
left a comment
There was a problem hiding this comment.
Nothing obvious that stands out. All the newly added files all exist on disk so I think it's a publish and see situation.
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13133
This PR adds an a new Oxide target for
wasm32-wasip1-threads:@tailwindcss/oxide-wasm32-wasi. The goal of this is to enable more environments to run Oxide, including (but not limited to) StackBlitz.We're making use of
napi-rs's upcoming v3 features to simplify the setup here, meaningnapi-rswill configure the WASM target and create an npm package that works across Node and browser environments.MacOS AArch64 issues
While setting up an integration test for the new WASM target, I ran into an issue where FS reads where not terminating on macOS. After some research I found this to be a limitation of the Node.js container interface right now, see: nodejs/node#47193
Windows issues
We also found that the Node.js wasi container does not properly support Windows: nodejs/uvwasi#11
For now we, it's probably best for MacOS AArch64 users and Windows users to use the native modules instead.
Test plan
The
@tailwindcss/oxide-wasm32-wasinpm package can be built locally viapnpm buildand then run with the Oxide API. A usage example can be taken from the newly added integration test.Furthermore this was tested to work as a polyfill on StackBlitz: https://stackblitz.com/edit/vitejs-vite-uks3gt5p
[ci-all]