Skip to content

Fix publish step on CI #17654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Fix publish step on CI #17654

merged 1 commit into from
Apr 11, 2025

Conversation

philipp-spiess
Copy link
Member

To publish the newly adde WASM builds, we rely on the node-linker=hoisted .npmrc flag that isn't read when pnpm --recursive is used. To work around it, this PR excludes the wasm package from the --recursive part and manually published it afterwards.

Test Plan

Ensured this does not error now when trying a --dry run.

Screenshot 2025-04-11 at 17 43 38

@philipp-spiess philipp-spiess requested a review from a team as a code owner April 11, 2025 15:48
@philipp-spiess philipp-spiess merged commit d801d8d into main Apr 11, 2025
7 checks passed
@philipp-spiess philipp-spiess deleted the fix/publish-script branch April 11, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants