Skip to content

Fix Windows CI #17785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows CI #17785

wants to merge 1 commit into from

Conversation

philipp-spiess
Copy link
Member

[ci-all]

@philipp-spiess philipp-spiess requested a review from a team as a code owner April 25, 2025 11:58
expect(await fs.dumpFiles('dist/*.css')).toMatchInlineSnapshot(`
"
"
`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean no file gets written to disk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so, will need further debugging if that makes the build pass but there were different error messages so this is just trying around haha

@philipp-spiess philipp-spiess marked this pull request as draft April 25, 2025 12:03
@philipp-spiess philipp-spiess marked this pull request as ready for review April 25, 2025 12:17
@philipp-spiess
Copy link
Member Author

guess i have to test this on windows to know what's going on but yeah looks like windows just doesn't create a file. maybe that's fine? neeeds to be tested in next etc tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants