Skip to content

Fix missing extracted classes containing . in Clojure #18038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented May 15, 2025

This PR fixes an issue in the Clojure pre-processor where candidates including . characters were not extracted correctly.

The solution here is to only replace the . with a when the . is not surrounded by numbers. This means that:

:.foo.bar

Becomes

: foo bar

But

:.gap-1.5.flex

Becomes

: gap-1.5 flex

This way the gap-1.5 is correctly extracted.

Test plan

  1. Added a test for this case
  2. Tested this in the extractor tool as well. Notice how the gap-1.5 is correctly extracted here.
image

Fixes: #17760

@RobinMalfait RobinMalfait requested a review from a team as a code owner May 15, 2025 12:06
@RobinMalfait RobinMalfait changed the title Fix extraction of candidates with . in Clojure Fix missing extracted classes containing . in Clojure May 15, 2025
@RobinMalfait RobinMalfait enabled auto-merge (squash) May 15, 2025 12:12
@RobinMalfait RobinMalfait merged commit bf591fe into main May 15, 2025
7 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-17760 branch May 15, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Candidate extraction from Clojure/Script files sometimes produce false negatives
2 participants