-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Handle @variant inside @custom-variant
#18885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f628ea8
add failing test
RobinMalfait 0dc5ab5
add topological sort utility
RobinMalfait 19949cc
add `substituteAtVariant` utility
RobinMalfait e3b4c4c
handle `@variant` inside `@custom-variant`'s
RobinMalfait 5f52530
use `substituteAtVariant` in main CSS handling
RobinMalfait 8ef8419
register `@custom-variant` in the correct topological order
RobinMalfait 6636897
update changelog
RobinMalfait 866ab4f
Merge branch 'main' into feat/use-variant-in-custom-variant
RobinMalfait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add
substituteAtVariant utility
- Loading branch information
commit 19949cc413027de3f5204d68f9e03245f7a3bb1d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we never mutate the selector of the
&node, then we could skip some layers by using:But the final result should be the same. This is also the same behavior we had before so I think we can keep it like this.