Skip to content

Show version mismatch when running upgrade tool #19028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 29, 2025
Merged

Show version mismatch when running upgrade tool #19028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
357221d
ensure `\n\n` are kept as `\n\n`
RobinMalfait Aug 27, 2025
ab7dda1
add expected Tailwind CSS version
RobinMalfait Sep 29, 2025
294fa85
error when there is a version mismatch
RobinMalfait Sep 29, 2025
c9dd535
add integration tests for pnpm, npm and bun
RobinMalfait Sep 29, 2025
f53cd0a
update changelog
RobinMalfait Sep 29, 2025
c9537f0
setup git config in CI
RobinMalfait Sep 29, 2025
ac36a04
set config globally
RobinMalfait Sep 29, 2025
11e1d71
strip VTControl characters to make CI happy
RobinMalfait Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
error when there is a version mismatch
  • Loading branch information
@RobinMalfait
RobinMalfait committed Sep 29, 2025
commit 294fa85dc778bde84cfb51a3b79385ac6642f7b0
22 changes: 22 additions & 0 deletions packages/@tailwindcss-upgrade/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Scanner } from '@tailwindcss/oxide'
import { globby } from 'globby'
import fs from 'node:fs/promises'
import path from 'node:path'
import pc from 'picocolors'
import postcss from 'postcss'
import { migrateJsConfig } from './codemods/config/migrate-js-config'
import { migratePostCSSConfig } from './codemods/config/migrate-postcss'
Expand Down Expand Up @@ -62,6 +63,27 @@ async function run() {
prefix: '↳ ',
})

if (version.installedTailwindVersion(base) !== version.expectedTailwindVersion(base)) {
let pkgManager = await pkg(base).manager()

error(
[
'Version mismatch',
'',
pc.dim('```diff'),
`${pc.red('-')} ${`${pc.dim('"tailwindcss":')} ${`${pc.dim('"')}${pc.blue(version.expectedTailwindVersion(base))}${pc.dim('"')}`}`} (expected version in package.json / lockfile)`,
`${pc.green('+')} ${`${pc.dim('"tailwindcss":')} ${`${pc.dim('"')}${pc.blue(version.installedTailwindVersion(base))}${pc.dim('"')}`}`} (installed version in \`node_modules\`)`,
pc.dim('```'),
'',
`Make sure to run ${highlight(`${pkgManager} install`)}, and try again.`,
].join('\n'),
{
prefix: '↳ ',
},
)
Comment on lines +69 to +83
Copy link
Member Author

@RobinMalfait RobinMalfait Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions here!

Copy link
Contributor

@thecrypticace thecrypticace Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would say "Tailwind CSS version mismatch" but other than that this seems fine to me.

Copy link
Contributor

@thecrypticace thecrypticace Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: I don't think it needs to change since tailwindcss is also prevent in the diff so if you don't wanna change it that's fine imo. 🤷‍♂️

Copy link
Member Author

@RobinMalfait RobinMalfait Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change if we want to show more issues. But I used the '↳' as well because it's sort of a continuation of the previous Tailwind CSS version

process.exit(1)
}

{
// Stylesheet migrations

Expand Down
3 changes: 3 additions & 0 deletions packages/@tailwindcss-upgrade/src/utils/packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ const manifests = new DefaultMap((base) => {

export function pkg(base: string) {
return {
async manager() {
return await packageManagerForBase.get(base)
},
async add(packages: string[], location: 'dependencies' | 'devDependencies' = 'dependencies') {
let packageManager = await packageManagerForBase.get(base)
let args = packages.slice()
Expand Down