-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Canonicalization constant folding and handling zeros #19095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
82417cf
parse `/` as a `word` in ValueParser
RobinMalfait 026c4db
add `walkDepth` to the ValueParser
RobinMalfait 9060d34
export `word` and `isLength` functions
RobinMalfait 4388ef0
add constant fold declaration functionality
RobinMalfait a92cd9d
handle `+` and `-` values, and make the unit optional
RobinMalfait ff49719
set `unit` to `null` in case there is no unit
RobinMalfait 895c5af
swap constant folding in the signature with new logic
RobinMalfait f12a879
add canonicalize utilities with `0` test
RobinMalfait 3d97eb5
prefer `mt-0` over `-mt-0`
RobinMalfait cdd9e9a
add a few more tests
RobinMalfait aadb54c
update changelog
RobinMalfait 0715b7e
Update packages/@tailwindcss-upgrade/src/codemods/template/migrate.te…
RobinMalfait d8d8a61
Update packages/tailwindcss/src/value-parser.ts
RobinMalfait 549f9a8
Update packages/tailwindcss/src/constant-fold-declaration.test.ts
RobinMalfait a71c765
Merge branch 'main' into feat/canonicalization-constant-folding
RobinMalfait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add canonicalize utilities with
0 test
This will rely on 2 things: 1. That we properly constant fold length units into `0` 2. That we prefer the "positive" version (`mt-0`) over its negative version (`-mt-0`)
- Loading branch information
commit f12a87905e81b7009bd112ab926876c37bcf5bd9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.