Incorporate changes from latest ignore crate - #19148
Merged
Merged
Conversation
thecrypticace
force-pushed
the
bump-ignore-crate
branch
from
October 18, 2025 17:39
4a995e7 to
d4c9519
Compare
thecrypticace
marked this pull request as ready for review
October 20, 2025 11:56
RobinMalfait
approved these changes
Oct 20, 2025
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Nice! I tested it on some projects and everything still works as expected.
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
We could add a changelog entry in case things break then we know why, but not sure if it's necesary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our internal fork of the
ignorecrate to incorporate changes from the latest release v0.4.24.Aside: We should look into opening issues about the changes we had to make to see if they could be addressed in the crate itself so we can get rid of our fork.