Skip to content

Conversation

@thecrypticace
Copy link
Contributor

Candidates that don’t pass this test already won’t get picked up by Oxide so shouldn’t be any worry of compatibility issues
@thecrypticace thecrypticace requested a review from a team as a code owner December 1, 2025 16:13
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

Adds a validation regex IS_VALID_NAMED_VALUE and applies it to named-value parsing paths in parseCandidate, parseModifier, and parseVariant, causing invalid named values to be rejected early or skipped. Test coverage is extended with three additional invalid named-value candidates. No public API or exported signatures were changed; only parsing behavior and tests were modified.

Pre-merge checks

✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: introducing validation for named values in the candidate parser to fix invalid syntax handling.
Description check ✅ Passed The description provides a reference to the linked issue that this PR addresses, relating to invalid named values in candidate parsing.
Linked Issues check ✅ Passed The PR implements validation of named values in the candidate parser to detect and prevent reporting of invalid arbitrary-variant-with-value syntax like 'data-hovered=true:text-red-500', addressing issue #1506's core objective.
Out of Scope Changes check ✅ Passed All changes are directly scoped to validation of named values in the candidate parser and related test coverage, with no unrelated modifications detected.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f6d61f and b40ea4b.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Linux / vite
  • GitHub Check: Linux / postcss
  • GitHub Check: Linux / upgrade
  • GitHub Check: Linux / cli
  • GitHub Check: Linux

Comment @coderabbitai help to get the list of available commands and usage tips.

@thecrypticace thecrypticace merged commit a5f4644 into main Dec 3, 2025
7 checks passed
@thecrypticace thecrypticace deleted the fix/invalid-named-values branch December 3, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arbitrary variant with value is incorrectly reported as valid syntax by LSP

2 participants