Skip to content

Fix failing postcss integration test - #19436

Merged
thecrypticace merged 2 commits into
mainfrom
fix/test-awaiting
Dec 12, 2025
Merged

Fix failing postcss integration test#19436
thecrypticace merged 2 commits into
mainfrom
fix/test-awaiting

Conversation

@thecrypticace

@thecrypticace thecrypticace commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

This is what's causing the postcss test in #19434 to fail wanted to test this in isolation without the version bumps

@thecrypticace
thecrypticace requested a review from a team as a code owner December 12, 2025 14:23
@coderabbitai

coderabbitai Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Updated test code in the PostCSS integration suite: one test in integrations/postcss/core-as-postcss-plugin.test.ts now awaits the expectation (await expect(...)) instead of returning it, and two tests in integrations/postcss/index.test.ts were adjusted to match a different stderr message string (from does-not-exist is not exported from package to "./does-not-exist" is not exported). No other logic, error handling, public API, or exported entities were changed.

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix failing postcss integration test' clearly summarizes the main change - fixing a failing test in the postcss integration by adding missing await statements.
Description check ✅ Passed The PR description directly relates to the changeset, referencing issue #19434 and explaining the purpose of adding missing await statements to tests.

Comment @coderabbitai help to get the list of available commands and usage tips.

@thecrypticace thecrypticace changed the title Add missing await to test Fix failing postcss integration test Dec 12, 2025
@thecrypticace
thecrypticace merged commit dd9f656 into main Dec 12, 2025
7 checks passed
@thecrypticace
thecrypticace deleted the fix/test-awaiting branch December 12, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant