fix(compat): map maxWidth to max-width namespace in v4 migration#19653
fix(compat): map maxWidth to max-width namespace in v4 migration#19653NssGourav wants to merge 3 commits intotailwindlabs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request changes the CSS property namespace mapping in 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
|
@RobinMalfait can you please review this pr and let me know anything to change |
Summary
In Tailwind CSS v4, the migration logic for v3 configurations incorrectly maps the
maxWidththeme key to the--container-*CSS variable namespace. This causes clashes with container query variables and breaks the primarymax-w-*utility design.This PR updates
OLD_TO_NEW_NAMESPACEto correctly mapmaxWidthtomax-width.Fixes #19555
Test Plan
Verified by updating existing core compatibility tests.
Execution command: