Switch from .npmignore to files option
#1981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks great, thanks @MartijnCuppens! I notice we lose the source maps for the CDN builds, I guess there's no real benefit to even generating those in the first place maybe? |
ae983a6 to
e794e3a
Compare
e794e3a to
727e742
Compare
Contributor
Author
|
The sourcemaps are indeed pretty useless since the only thing I've now removed the sourcemaps in a separate commit. New overview of which files are being published: https://www.diffchecker.com/sKSlBHOr |
Member
|
Thanks @MartijnCuppens! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867
See comparison between what files are published here: https://www.diffchecker.com/NhRXqAQj
I stripped out the most obvious files, but I'm unsure if all CSS/JS files that are published are needed.