Add class-table partial to make class tables more maintainable #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Gonna add the Vue component to this PR too what the hell. So I guess we won't merge til that's all good 😄
|
Better Algolia indexing and stuff and just simpler overall.
Contributor
|
@adamwathan Nice addition maybe, would be to have the header be sticky? 🙂 |
Member
Author
|
@MichaelDeBoey Considered it for about 30 seconds then realized it would be hell because the column widths are dynamic and I can't see a way to make it sticky without splitting it away from the other table, and trying to synchronize the widths between two tables sounds horrible 😄 |
Contributor
|
@adamwathan The custom Vue component would help a bit better I think? But indeed maybe not worth the work... 🙂 |
DCzajkowski
pushed a commit
to DCzajkowski/tailwindcss
that referenced
this pull request
Jul 23, 2019
Change URL references from next to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Blade partial to the docs that lets you pass in the data for a class table as an array instead of duplicating that table markup everywhere.
I've converted background colors and background position as an example, but it's fine for us to merge this without converting everything at once.
The ultimate goal is to add a Vue component for this that only shows the first x rows by default, with a "Show all" link at the bottom. That way super long class tables won't disguise the fact that there's other documentation below like they do now.