Preserve HTML elements by default when purging unused styles - #2283
Merged
Conversation
|
Does this make https://github.com/tailwindlabs/blog.tailwindcss.com/blob/master/tailwind.config.js#L12-L22 unnecessary for MDX files? |
Member
Author
|
@pikeas Yep not necessary anymore, although what we've done there is even more optimized (but way past the point of diminishing returns). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
preserveHtmlElementsoption to thepurgeconfiguration that allows you to safelist all plain HTML elements, likep,blockquote,body,video, etc.This helps avoid accidentally purging things like heading elements when your source files are in a format that compiles to HTML, like markdown (since your markdown won't actually contain the string
h1anywhere).This option is set to
trueby default.On its own this PR won't change anything for anyone really, but I plan to change things to purge all of
base,components, andutilitiesgoing forward (not justutilities), as this was the only real footgun until now, and with the new typography plugin gaining traction it would be nice to make those styles purgeable by default.