Update navigation.blade.md #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `sm:hidden` so the `a` links are hidden on small screens for a full responsive menu.
Member
|
Hey @matthewtrask thanks for the PR! This is actually by design to show the open state of the navigation with the menu expanded on small screens 👍 If anything I might update it to be interactive to show both states, but I still think defaulting to open is more useful; it's a lot easier to cheat at the implementation if you don't have to show how the expanded state works, haha... |
Author
|
Ah cool! Wasn't sure, but wanted to check, cheers! |
DCzajkowski
pushed a commit
to DCzajkowski/tailwindcss
that referenced
this pull request
Jul 23, 2019
Update to v1.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sm:hiddenso thealinks are hidden on small screens for a full responsive menu.It was opened as an issue here: tailwindlabs/discuss#68
If you collapse the page, the menu items are not hidden. If this is by design then cool, but figured I would open this and see what yall thought.