[0.3] Remove redundant default option fallbacks #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when trying to determine the
importantandprefixvalues in the config, we fall back using lodash to hardcoded defaults directly in the plugin code.These fallbacks are unnecessary since the default options are merged with the user's options way earlier in the processing chain.
This PR removes those redundant fallbacks, and also adds some messaging around these options being "advanced", and that they aren't intended to really be tweaked just for fun. We had considered not including this section in the generated default config at all for that reason, but doing that introduces unnecessary complexity right now, and also makes these options less discoverable for the people who may actually need them.