[0.3] Remove margins on lists by default #254
Conversation
|
|
||
| ol, | ||
| ul { | ||
| margin: 0; |
There was a problem hiding this comment.
Would it make more sense to move this to our basecss fork?
There was a problem hiding this comment.
I considered that but those selectors are in alphabetical order, and keeping things in alphabetical order would separate ol and ul from each other 🤔 So opted to just keep it as an explicit rule, although I'm also happy to move it there if you think that's better.
There was a problem hiding this comment.
Nah I don't care that much. My only thinking was trying to keep normalize as standard as possible, and then only making tweaks to our basecss fork.
But maybe we're already making other (non-comment) changes to normalize?
There was a problem hiding this comment.
It is in the SUIT CSS Base fork, not in Normalize. I’m confused?
Currently margins are removed in the
list-resetclass.We remove margins by default on all kinds of other elements, so it seems reasonable to me to remove them by default on lists too, leaving
list-resetto only handle removing the list style and the left padding.Without this, lists will have some non-standard margin on the top and bottom by default that uses a value from outside of Tailwind's spacing config, which seems like an unnecessary inconsistency.
I'm also considering changing
list-resettolist-style-noneand putting the onus on the user to remove the padding, but also happy to make that a separate PR, and still not entirely convinced on it anyways.