Include default config by default in presets#2660
Merged
adamwathan merged 1 commit intomasterfrom Oct 23, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if your preset omitted the
presetskey, it would extend nothing. I thought this made sense originally but it doesn't — it's very unexpected behavior. It means that when you take a config from a project and extract it as a preset, it no longer extends the default config, so your preset behaves differently than it would when used directly as a config.I will backport this to 1.9 because this is so unexpected that I would consider it a bug. If you want to create a preset that extends nothing, you just needs to add
presets: []to your preset.