Account for Svelte class bindings at the start of a line - #4187
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4187 +/- ##
=======================================
Coverage 86.84% 86.84%
=======================================
Files 341 341
Lines 4836 4836
Branches 919 919
=======================================
Hits 4200 4200
Misses 561 561
Partials 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks @bradlc! |
adamwathan
pushed a commit
that referenced
this pull request
May 7, 2021
* add failing svelte syntax test case * account for svelte class bindings at the start of a line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4181
This PR updates the Svelte class binding regular expression so that it catches instances at the start of a line.
Consider the following example:
Because the class extractor runs for each trimmed line separately, in this case it runs against
class:bg-red-500={current === 'foo'}. The regular expression did not match the class binding because there is no whitespace before it.The regular expression has been updated to look for either whitespace or the start of the string, which fixes the issue.