Skip to content

Conversation

@nailuj29
Copy link

@nailuj29 nailuj29 commented Apr 28, 2021

Some people spell gray as grey, so this PR should prevent any confusion

@pmonks
Copy link

pmonks commented Apr 28, 2021

And by "some people", am I right to assume that you mean "a majority of people who read & write the English language"? Only around 25% of English speakers on earth spell this word "gray".

@nailuj29
Copy link
Author

@pmonks yes, you would be correct

@adamwathan
Copy link
Member

Hey! This significantly increases the file size of Tailwind in development mode, as well as in the CDN build, so not going to merge unfortunately. You can rename gray to grey in your own config file if you want — you're encouraged to name your colors whatever you like.

I chose gray because that's how it is spelled in the native CSS APIs, like:

.grayscale {
  filter: grayscale(1)
}

@adamwathan adamwathan closed this Apr 28, 2021
@nailuj29
Copy link
Author

@adamwathan The color grey is spelled both ways in CSS. See this image:
image

@nailuj29
Copy link
Author

Also, most people will be using something like PurgeCSS in production, so the increase in file size doesn't really matter.

@nailuj29
Copy link
Author

@adamwathan just tested it, and it only increases the size by .2 megabytes, which isn't much at all.
image
The top one had no grey, and the bottom one did

@jsonkody
Copy link

jsonkody commented Apr 24, 2024

I was constantly writing grey-... which is not working and then found out that I am not crazy, just the English is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants