Generate plugin list file - #4725
Merged
Merged
Conversation
Removes the importing of all plugins in src/util/resolveConfig to avoid importing CSS. Import the built plugin list file instead.
fedeci
reviewed
Jun 21, 2021
Comment on lines
+1
to
+10
| import * as corePlugins from '../src/plugins' | ||
| import fs from 'fs' | ||
| import path from 'path' | ||
|
|
||
| const corePluginList = Object.keys(corePlugins) | ||
|
|
||
| fs.writeFileSync( | ||
| path.join(__dirname, '..', 'src', 'corePluginList.js'), | ||
| `export default ${JSON.stringify(corePluginList)}` | ||
| ) |
Contributor
There was a problem hiding this comment.
Q: Since this logic is only used by resolveConfig.js can we not generate the file and directly move this to resolveConfig.js?
Contributor
Author
There was a problem hiding this comment.
This would make it so we would have to commit a generated file to the repo. It would also have to conform to the linter. Is this desired behavior?
Contributor
There was a problem hiding this comment.
I meant something more similar to the older logic.
Contributor
Author
There was a problem hiding this comment.
I'm confused as to what this means. We cannot do this in resolveConfig.js because it would mean a package consumer would have to import all the plugins and thus import CSS from the preflight plugin. See linked issue for why this is a problem.
Contributor
There was a problem hiding this comment.
Since exports are transpiled to commonjs, there may exist some trick to get a list of all of them. Just suppositions though.
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
fedeci
reviewed
Jun 22, 2021
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
Member
|
Thanks, I'll publish a new release with this fix today 👍🏻 Long-term though it's still way better to not have this stuff in your client-side bundle at all. You can look at the tailwindcss.com repo if you want to see how we do this ourselves with preval. resolveConfig carries with it some really big dependencies you don't want to ship to the client. |
|
This actually prevents npm or yarn from installing on my system: Edit: Using Node v12. Same result with Node V14: |
Contributor
Author
|
Breaks mine too. Quick fix would be to remove the install script. @adamwathan. Strange because I actually created a discussion over at the NPM repository and was told to use this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the importing of all plugins in
src/util/resolveConfigto avoid importing CSS.Import the built plugin list file instead.
resolves #4681