Skip to content

JIT: Optimize universal selector usage by inlining only the relevant selectors #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 13 commits into from
Jul 1, 2021
Merged

JIT: Optimize universal selector usage by inlining only the relevant selectors #4850

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2926cad
WIP
adamwathan Jun 30, 2021
5d8d16e
run prettier
RobinMalfait Jun 30, 2021
5012cd9
drop new lines in custom matcher
RobinMalfait Jun 30, 2021
88fffad
add cache for the selector parser
RobinMalfait Jun 30, 2021
2d327c1
add `@apply` tests for the universal optimizer
RobinMalfait Jun 30, 2021
1473ec2
drop comments
RobinMalfait Jun 30, 2021
6dbd28c
initial replacements
RobinMalfait Jun 30, 2021
4e912e6
WIP
RobinMalfait Jun 30, 2021
b540c4b
WIP
RobinMalfait Jun 30, 2021
6756a82
MAKE IT WORK
adamwathan Jun 30, 2021
c5e13c6
Rename to resolveDefaultsAtRules
adamwathan Jul 1, 2021
34779b4
Update tests + defaults identifiers
adamwathan Jul 1, 2021
9ae1f7a
Don't add @defaults in AOT mode
adamwathan Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop comments
  • Loading branch information
@RobinMalfait
RobinMalfait committed Jun 30, 2021
commit 1473ec2749ef12b836bc54dfee0cd33711832098
9 changes: 0 additions & 9 deletions src/jit/lib/optimizeUniversalRules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ function extractElementSelector(selector) {

export default function collapseAdjacentRules() {
return (root) => {
// Walk all custom properties
// Collect into a map, where key is the custom property name
// Value is list of nodes
// Walk '*::tailwind' rules
// Get list of selectors per custom property
// Compute element selector (remove pseudo-classes, leading selectors, etc.)
// Collect selectors into Set
// Replace '*::tailwind' with selectors from Set

let variableNodeMap = new Map()
let universals = new Set()

Expand Down