Enable more variants by default #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamwathan Don't forget to change the variants in the docs either. (Do I make a PR for it?) |
|
@MichaelDeBoey Yeah definitely need to do that, would welcome a PR if you're around to do it today, if not I'll get to it myself at some point before the end of the day 👍 |
|
@adamwathan PR is on it's way 😉 |
|
@adamwathan You can check tailwindlabs/tailwindcss.com#25 for the PR 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the following variants by default:
It adds significant size to the CDN builds but it makes the default build much more useful out of the box. We have thorough documentation on managing build size so I think it's silly to cripple the default build just to make the framework appear smaller to people who don't spend the time to learn about how it actually works.