Process tailwind features together #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #519.
The way Webpack runs PostCSS stuff is a little hard to fully understand — some stuff seems to run only once, some stuff runs every time a build happens, etc.
As part of a refactoring in an earlier commit, I tried to extract all of Tailwind's processing to it's own plugin so I could stop passing around
lazyConfigeverywhere and still have changes totailwind.jsbe respected on watch, but apparently I wasn't properly testing that it was still working because I broke it 🙃After some googling and trial and error, I figured out I can wrap all of these plugins in another plugin that runs all of the plugins synchronously, and this will cause Webpack to properly respect changes to the config file. Fingers crossed there are no unwanted side effects here, but I think we'll have to just throw it into the wild to know for sure.