Clear up wording of the Advanced screens section. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's definitely clearer, thank you! |
DCzajkowski
pushed a commit
to DCzajkowski/tailwindcss
that referenced
this pull request
Jul 23, 2019
Fix typo in visibility.blade.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for the amazing work guys. I've been waiting for the premier for a while now and I'm crazy excited about it! Going through the docs and intend to put this into use ASAP.
Secondly, I didn't know if it's okay to PR against master or I should have created a feature branch (not sure what's the best practice for this project) so I apologise for potential mistake :).
Lastly:
The initial form of the comment seemed to claim that main content area is wide enough to apply md: styles between 768px and 868px, which is not what you guys meant. I'm not a native speaker, but I think I've cleared up the wording, because the sentence seemed to contradict itself. Of course, you can still improve my change with even better wording.
I understand that the example shown says:
Apply sm from 500px upwards.
Apply md from 668px to 767px.
Revert to sm here.
Apply md from 868px upwards.
Thanks!