Handle unknown typehints #5588
Merged
Handle unknown typehints #5588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use a typehint like `w-[length:12px]`, then currently that wouldn't generate anything because we don't have a matchUtilities for `w` with a `length` type. To fix this, we can detect if this is unnecessary, if it is we still generate the expected outcome. (In this case `width: 12px`) but we also warn to the user that we detected this. Currently we detect this by checking if there is only a single plugin registered for handling the prefix (e.g.: `w-`). We can probably improve this by also checking all the types that all plugins are handling for the resolved plugins.
118e425 to
850a8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves unnecessary typehints. If we know that only a single plugin is handling
win this case, then any typehints can be ignored because the contents of the arbitrary values can accept anything (due to the (default)anytypehint).input:
output:
However, this will also provide you with a warning in the terminal output:
We can remove warning if it is too much noise, but it is nice that we can detect this behaviour.
The current heuristic is to check whether only a single plugin exists that handles a certain prefix (
w-).