Resolve overflow-clip naming collision issue
#5630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4622
With
overflow: clipbecoming more widely supported by browsers, we are running into a naming collision with the existingoverflow-cliputility, which setstext-overflow: clip.This PR renames the existing
text-overflowutilities as following:overflow-ellipsistext-ellipsisoverflow-cliptext-clipWe considered using
ellipsisandclipfor these utilities, but using the prefix makes these utilities more resilient to new values being supported in the future. For example, Firefox already supports values liketext-overflow: "-".Renaming
overflow-cliptotext-clipis a breaking change, but I expect the impact will be very low, sincetext-overflow: clipis the browser default, and there are very few reasons to actually use that class.We are not removing the existing
overflow-ellipsisutility because that would be an unnecessary breaking change, but it is now considered deprecated, and will no longer be documented.With the
overflow-clipclass now available, we've also added the newoverflow: cliputilities:overflow-clipoverflow: clipoverflow-x-clipoverflow-x: clipoverflow-y-clipoverflow-y: clip