Skip to content

Fix for border-style in preflight#565

Closed
kylemilloy wants to merge 1 commit intotailwindlabs:masterfrom
kylemilloy:fix-564
Closed

Fix for border-style in preflight#565
kylemilloy wants to merge 1 commit intotailwindlabs:masterfrom
kylemilloy:fix-564

Conversation

@kylemilloy
Copy link

@kylemilloy kylemilloy commented Oct 1, 2018

Resolves specific issue with Google Maps as tracked here: #564

Adds the following to preflight.css:

* {
border-style: inherit;
}

Which prevents some weird bugs when you're trying to make CSS triangles via border-width and using absolute positioning.

This will cause API breaking changes to how classes like @apply border; work however (you'll have to manually set the border-style).

@kylemilloy kylemilloy changed the title Fix for border-style in preflight Fix for border-style in preflight #564 Oct 1, 2018
@kylemilloy kylemilloy changed the title Fix for border-style in preflight #564 Fix for border-style in preflight Oct 1, 2018
@adamwathan
Copy link
Member

This unfortunately breaks the ability to just add border to a div and have a border appear, since those utilities only adjust the border-width.

Our border reset styles are admittedly quite opinionated in this regard, but no plans to change them for this because the trade-off is too annoying :/

The recommended fix is to add your own CSS to target and fix the map element, as discussed in this earlier issue:

#484

@kylemilloy
Copy link
Author

Fair enough.

@kylemilloy kylemilloy closed this Oct 1, 2018
thecrypticace pushed a commit that referenced this pull request Jun 24, 2025
Here is everything you need to know about this update. Please take a
good look at what changed and the test results before merging this pull
request.

### What changed?




#### ✳️ postcss-import (16.1.0 → 16.1.1) ·
[Repo](https://github.com/postcss/postcss-import) ·
[Changelog](https://github.com/postcss/postcss-import/blob/master/CHANGELOG.md)



<details>
<summary>Release Notes</summary>

<h4>16.1.1 (from changelog)</h4>
<blockquote><ul dir="auto">
<li>Fix incorrect cascade layer order when some resources can not be
inlined (<a
href="https://bounce.depfu.com/github.com/postcss/postcss-import/issues/567">#567</a>,
<a
href="https://bounce.depfu.com/github.com/postcss/postcss-import/pull/574">#574</a>)</li>
</ul></blockquote>
<p><em>Does any of this look wrong? <a
href="https://depfu.com/packages/npm/postcss-import/feedback">Please let
us know.</a></em></p>
</details>

<details>
<summary>Commits</summary>
<p><a
href="https://github.com/postcss/postcss-import/compare/9217ec361b8d0b062841d5634f40017aeaad078b...4ae9894edc6bced4ad983c5556de493d77c8cc6d">See
the full diff on Github</a>. The new version differs by 10 commits:</p>
<ul>
<li><a
href="https://github.com/postcss/postcss-import/commit/4ae9894edc6bced4ad983c5556de493d77c8cc6d"><code>16.1.1</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/a3f38897da54e61bcb4a34484dc6a6c0543134bc"><code>Test
on modern Node versions (#577)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/10325fc02498da689d3c6f2821c6448c6064831c"><code>Upgrade
eslint &amp; config; use flat config (#576)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/92276420402a400566f30d7b494f8b51ef76b0f1"><code>Migrate
config renovate.json (#575)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/25441554913ca9f4f8469636ef7001d9cdbdb832"><code>Update
dependency prettier to ~3.5.0 (#572)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/83108aa207e96eeac159dde08e2153cddeb7172e"><code>Fix
incorrect cascade layer order when some resources can not be inlined
(#574)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/cad00220bf02f881be6475e943c499906b623241"><code>Update
dependency sugarss to v5 (#568)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/32deb082c687c0d324e5812b3593f7e44af10166"><code>Update
dependency c8 to v10 (#565)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/d43ca1506d65d9943a3c4bb885aff94dc809d69c"><code>Update
dependency prettier to ~3.4.0 (#569)</code></a></li>
<li><a
href="https://github.com/postcss/postcss-import/commit/9af465e598b51f933ac15baeab09caf086c3083b"><code>Update
dependency prettier to ~3.3.0 (#564)</code></a></li>
</ul>
</details>












---
![Depfu
Status](https://depfu.com/badges/edd6acd35d74c8d41cbb540c30442adf/stats.svg)

[Depfu](https://depfu.com) will automatically keep this PR
conflict-free, as long as you don't add any commits to this branch
yourself. You can also trigger a rebase manually by commenting with
`@depfu rebase`.

<details><summary>All Depfu comment commands</summary>
<blockquote><dl>
<dt>@​depfu rebase</dt><dd>Rebases against your default branch and
redoes this update</dd>
<dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits
that you've made to it</dd>
<dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and
conflicts are resolved</dd>
<dt>@​depfu cancel merge</dt><dd>Cancels automatic merging of this
PR</dd>
<dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd>
<dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if
it's closed)</dd>
<dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency
and closes this PR</dd>
<dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major
updates for this dependency and closes this PR</dd>
<dt>@​depfu resume</dt><dd>Future versions of this dependency will
create PRs again (leaves this PR as is)</dd>
</dl></blockquote>
</details>

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants