Fix debug mode being active although explicitly disabled #5837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Linking chromaui/chromatic-cli#429 |
Member
|
Hey! Thank you for your PR! Yep this makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to migrate to Tailwind v3.0.0-alpha.1 but got blocked by a
ReferenceError: contentMatchCache is not definederror which got fixed already in an unreleased commit.After some investigating I found out that Chromatic which I use for building and deploying Storybook on CI sets the environment variable
DEBUG=0during the build.Because the condition
process.env.DEBUG === '0'still sets the debug mode to true within Tailwind, there is no way for me to disable the debug mode in Tailwind if it was set by another library. I think it makes sense to disable the debug mode if it's specifically'0'.Let me know what you think. 😊