-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Restructure config file for 1.0 #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
664f923
Move prefix option to top-level in config
adamwathan 1a46f6b
Move important to top level option
adamwathan e8d16fc
Move separator to top level config option
adamwathan 326f35a
Remove options key from config
adamwathan 2f9172c
Update every plugin to accept its config as a parameter
adamwathan 99b5e90
Move all config values back to single file
adamwathan 3d2a598
Don't test for presence of defaultConfig in defaultConfig
adamwathan f10f182
Remove special "modules" merge behavior
adamwathan 760e93b
Use user's specified default border color
adamwathan fd22dea
Always load core plugins by default
adamwathan 95bb283
Rename defaultPlugins to corePlugins
adamwathan c56ae6c
Move modules outside of styles to top level key
adamwathan d98e97f
Rename modules to variants
adamwathan 3fbd6b3
Disable plugins using corePlugins instead of variants
adamwathan efc7927
Rename styles to theme
adamwathan 6533679
Inline theme into default config
adamwathan f8ddb76
Remove theme comments
adamwathan ec1bdd2
Move screens into theme config
adamwathan f3097f9
Move colors inside of theme
adamwathan b036cac
Fix code style
adamwathan ffdc2b0
Intelligently deep merge user's config
adamwathan 195cdec
Don't skip CLI tests
adamwathan a4bdae4
Extract default theme to separate file
adamwathan 083ab97
Fix code style
adamwathan d165661
Fix failing test
adamwathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
module.exports = { | ||
screens: { | ||
mobile: '400px', | ||
theme: { | ||
screens: { | ||
mobile: '400px', | ||
}, | ||
}, | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,6 @@ | |
@responsive { | ||
.example { | ||
@apply .font-bold; | ||
color: config('colors.red'); | ||
color: config('theme.colors.red'); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about checking for
defaultTheme
instead of dropping this assertion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what I even want to scaffold for the config file when people use
tailwind init
yet so just gonna punt on it entirely for now I think.