Use configured bold for strong tags #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
884b236 to
0d25dd2
Compare
adamwathan
added a commit
that referenced
this pull request
Mar 18, 2019
adamwathan
added a commit
that referenced
this pull request
Mar 18, 2019
Revert #745, always default to bolder for strong tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the configured 'bold' weight for
strongelements by default, falling back to 'bolder' (as per normalize.css) if there is no configured 'bold' weight.This isn't perfect as there's no guarantee the user wants to use
bolderforstrongtags if they've changed the name of their font-weight classes, but it's one of those "slightly better than what we had before, and definitely not in any way worse" improvements that there's no reason not to make.