Skip to content

Use local user css cache for apply #7524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 25, 2022
Merged

Use local user css cache for apply #7524

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3dd521e
Fix context reuse test
thecrypticace Feb 16, 2022
d442ac5
Don't update files with at-apply when content changes
thecrypticace Feb 16, 2022
326bf53
Prevent at-apply directives from creating new contexts
thecrypticace Feb 16, 2022
8fccb99
Rework apply to use local postcss root
thecrypticace Feb 18, 2022
a24e794
Don’t build local cache unless `@apply` is used
thecrypticace Feb 24, 2022
89c4f68
Speed up structural cloning
thecrypticace Feb 24, 2022
f5e37c6
Simplify
thecrypticace Feb 25, 2022
5302fc6
Change to let
thecrypticace Feb 25, 2022
490e8bc
Update test name
thecrypticace Feb 25, 2022
a602a79
Change which offset is user
thecrypticace Feb 25, 2022
0b450fa
Add comments
thecrypticace Feb 25, 2022
c78aa7b
Update changelog
thecrypticace Feb 25, 2022
29bc320
Fix test name
thecrypticace Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don’t build local cache unless @apply is used
  • Loading branch information
@thecrypticace
thecrypticace committed Feb 24, 2022
commit a24e7945b59a4bc5579dd05f5b659c7476c083b9
23 changes: 22 additions & 1 deletion src/lib/expandApplyAtRules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,27 @@ function buildApplyCache(applyCandidates, context) {
return context.applyClassCache
}

/**
* @param {() => ApplyCache} buildCacheFn
* @returns {ApplyCache}
*/
function lazyCache(buildCacheFn) {
let cache

return {
get: (name) => {
cache = cache || buildCacheFn()

return cache.get(name)
},
has: (name) => {
cache = cache || buildCacheFn()

return cache.has(name)
},
}
}

/**
* @param {ApplyCache[]} caches
* @returns {ApplyCache}
Expand Down Expand Up @@ -398,7 +419,7 @@ function processApply(root, context, localCache) {

export default function expandApplyAtRules(context) {
return (root) => {
let localCache = buildLocalApplyCache(root, context)
let localCache = lazyCache(() => buildLocalApplyCache(root, context))

processApply(root, context, localCache)
}
Expand Down