Combine wrap-normal and break-normal, rename wrap-break to break-words #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #571 we added a
.break-all
utility and renamed.break-words
to.wrap-break
because we decided it made sense to have.wrap-normal
and.break-normal
as separate "reset" utilities, since they target different properties.In practice I think this is wasting an opportunity to make things easier for the end user, so this PR tweaks things so that wrap-break is back to
.break-words
, and.break-normal
now resets both word-break and overflow-wrap.In my testing there are no situations where it ever makes sense to add
break-words
andbreak-all
to the same element, becausebreak-all
always takes precedence, so we might as well treat these like they are manipulating the same property and provide a little normalization for the end user.Here's a more readable diff: