Register config file with Webpack for watching #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tells Webpack (for those using it) that the config file used should be tracked as a dependency and that the CSS should be re-compiled if that config file changes. It's careful to make sure the config file is loaded fresh every single time to avoid weird caching issues.
reinink
reviewed
Nov 3, 2017
| @@ -1,4 +1,5 @@ | |||
| var config = require('../defaultConfig') | |||
| var config = require('../lib/index').defaultConfig() | |||
|
|
|||
There was a problem hiding this comment.
Was this extra line return really necessary Adam?
vcavallo
reviewed
Jun 11, 2018
|
Hi guys. Any idea how to make it work with https://github.com/parcel-bundler/parcel v1.12? Currently I have to remove cache directory in order for it to catch the changes and re-bundle CSS. Oh, before posting this comment I've found a related Parcel issue parcel-bundler/parcel#2983, and it turns out that the pull request parcel-bundler/parcel#3980 was merged into Parcel 2.0 (not 1.x). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tells Webpack (for those using it) that the config file used should be tracked as a dependency and that the CSS should be re-compiled if that config file changes.
It's careful to make sure the config file is loaded fresh every single time to avoid weird caching issues.
Resolves #55 🙌