Skip to content

Do not set / 1 opacity for rgb/hsl helpers #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not set / 1 opacity for rgb/hsl helpers #8183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/util/resolveConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const configUtils = {

return ({ opacityValue }) => {
if (opacityValue === undefined || opacityValue === 1) {
return `rgb(var(${property}) / 1.0)`
return `rgb(var(${property}))`
}

return `rgb(var(${property}) / ${opacityValue})`
Expand All @@ -90,7 +90,7 @@ const configUtils = {

return ({ opacityValue }) => {
if (opacityValue === undefined || opacityValue === 1) {
return `hsl(var(${property}) / 1)`
return `hsl(var(${property}))`
}

return `hsl(var(${property}) / ${opacityValue})`
Expand Down
24 changes: 12 additions & 12 deletions tests/opacity.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,37 +209,37 @@ it('can use rgb helper when defining custom properties for colors (opacity plugi
return run('@tailwind utilities', config).then((result) => {
expect(result.css).toMatchFormattedCss(css`
.divide-primary > :not([hidden]) ~ :not([hidden]) {
border-color: rgb(var(--color-primary) / 1);
border-color: rgb(var(--color-primary));
}
.divide-primary\/50 > :not([hidden]) ~ :not([hidden]) {
border-color: rgb(var(--color-primary) / 0.5);
}
.border-primary {
border-color: rgb(var(--color-primary) / 1);
border-color: rgb(var(--color-primary));
}
.border-primary\/50 {
border-color: rgb(var(--color-primary) / 0.5);
}
.bg-primary {
background-color: rgb(var(--color-primary) / 1);
background-color: rgb(var(--color-primary));
}
.bg-primary\/50 {
background-color: rgb(var(--color-primary) / 0.5);
}
.text-primary {
color: rgb(var(--color-primary) / 1);
color: rgb(var(--color-primary));
}
.text-primary\/50 {
color: rgb(var(--color-primary) / 0.5);
}
.placeholder-primary::placeholder {
color: rgb(var(--color-primary) / 1);
color: rgb(var(--color-primary));
}
.placeholder-primary\/50::placeholder {
color: rgb(var(--color-primary) / 0.5);
}
.ring-primary {
--tw-ring-color: rgb(var(--color-primary) / 1);
--tw-ring-color: rgb(var(--color-primary));
}
.ring-primary\/50 {
--tw-ring-color: rgb(var(--color-primary) / 0.5);
Expand Down Expand Up @@ -361,37 +361,37 @@ it('can use hsl helper when defining custom properties for colors (opacity plugi
return run('@tailwind utilities', config).then((result) => {
expect(result.css).toMatchCss(css`
.divide-primary > :not([hidden]) ~ :not([hidden]) {
border-color: hsl(var(--color-primary) / 1);
border-color: hsl(var(--color-primary));
}
.divide-primary\/50 > :not([hidden]) ~ :not([hidden]) {
border-color: hsl(var(--color-primary) / 0.5);
}
.border-primary {
border-color: hsl(var(--color-primary) / 1);
border-color: hsl(var(--color-primary));
}
.border-primary\/50 {
border-color: hsl(var(--color-primary) / 0.5);
}
.bg-primary {
background-color: hsl(var(--color-primary) / 1);
background-color: hsl(var(--color-primary));
}
.bg-primary\/50 {
background-color: hsl(var(--color-primary) / 0.5);
}
.text-primary {
color: hsl(var(--color-primary) / 1);
color: hsl(var(--color-primary));
}
.text-primary\/50 {
color: hsl(var(--color-primary) / 0.5);
}
.placeholder-primary::placeholder {
color: hsl(var(--color-primary) / 1);
color: hsl(var(--color-primary));
}
.placeholder-primary\/50::placeholder {
color: hsl(var(--color-primary) / 0.5);
}
.ring-primary {
--tw-ring-color: hsl(var(--color-primary) / 1);
--tw-ring-color: hsl(var(--color-primary));
}
.ring-primary\/50 {
--tw-ring-color: hsl(var(--color-primary) / 0.5);
Expand Down