Remove dependency on perfectionist, implement simple formatting from scratch #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Any plans on turning this into a full-featured alternative to Perfectionist? |
Member
Author
|
Nah :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #817, simplifies a bunch of stuff too.
Also noticed some inconsistencies in values we were using in the config (some had leading zeroes, others didn't, some had spaces between commas, others didn't, etc.) so cleaned all that up as well, as we were accidentally relying on perfectionist to do that for us.
Also fixed a small bug in the
themefunction where array values were implicitly being converted to a string by Node instead of us handling that explicitly.